Add skill creation guidelines based on writing-skills (#70)#74
Merged
Conversation
Integrate writing-skills guidelines into skern's skill create workflow: - Update DefaultBody() scaffold with recommended sections (Overview, When to Use, Core Pattern, Quick Reference, Common Mistakes) - Update default description to start with "Use when..." (CSO guideline) - Add lint hints for description trigger prefix and missing body sections - Add Writing Skills Guidelines section to AGENTS.md - Add docs/guide/writing-skills.md documentation page - Add comprehensive tests for new lint rules Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Move docs/guide/writing-skills.md to docs/writing-skills.md and
trim AGENTS.md to a summary that links to the dedicated doc
- Expand trigger-phrase prefixes ("Use for/to", "Trigger when",
"Apply when") and add "overview" to recommended body sections
- Match recommended sections by markdown heading rather than
substring to avoid false positives from inline mentions
- Ignore .claude/ agent workspace
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Guard the central UX promise of the writing-skills guidelines integration: NewSkill + DefaultBody + defaultDescription must together pass lintStyle with zero hints. If any of those drift out of sync with a future lint-rule addition, this test fails. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skill createworkflow as default behaviorDefaultBody()scaffold to include recommended sections: Overview, When to Use, Core Pattern, Quick Reference, Common MistakesAGENTS.mddocs/guide/writing-skills.mddocumentation page with sidebar entryTest plan
TestValidate_ValidSkilluses a fully guideline-compliant skill and produces zero issuesTestLintStyle_NoHintsconfirms a well-structured skill triggers no hintsgo vet ./...passesmake testpassesCloses #70
🤖 Generated with Claude Code